Merged
Conversation
Contributor
Author
|
@tunetheweb please, need your help. I have no idea where to start with the failing check. |
Member
|
Rerunning it as looks like a bad run! |
tunetheweb
approved these changes
Jun 5, 2025
Member
tunetheweb
left a comment
tunetheweb
left a comment
There was a problem hiding this comment.
It looks to me like Lighthouse is crashing in CI. Not sure why, but I can't see it being related to your change. We'll assume it's flakey for now and I'll take a closer look later if it's still happening.
FYI, I did add one other typo fix I spotted when investigating.
Good to merge and release this.
Contributor
Author
|
There are many 4XX of missing icons, but I think these existed before. Thanks, merging |
Member
|
I think the 404s are due to this: #1043 (comment) that we said we'd fix in a follow up PR once your new API changes were live (which they are now I presume!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.